Always set xwidget title if the event was "load-finished"
authorPo Lu <luangruo@yahoo.com>
Tue, 9 Nov 2021 06:46:48 +0000 (07:46 +0100)
committerLars Ingebrigtsen <larsi@gnus.org>
Tue, 9 Nov 2021 06:47:17 +0000 (07:47 +0100)
* lisp/xwidget.el (xwidget-webkit-callback): Always set title upon
load completion.  This prevents loading pages such as "about:blank"
from not setting the buffer name (bug#51702).

lisp/xwidget.el

index fc37798322505d0d1abf94c5d07266c0a2f73500..905327083b653aad58ed948c69561426d0bb1293 100644 (file)
@@ -360,9 +360,11 @@ XWIDGET instance, XWIDGET-EVENT-TYPE depends on the originating xwidget."
     (cond ((eq xwidget-event-type 'load-changed)
            (let ((title (xwidget-webkit-title xwidget)))
              ;; This funciton will be called multi times, so only
-             ;; change buffer name when get a valid title. this can
-             ;; limit buffer-name flicker in mode-line.
-             (when (> (length title) 0)
+             ;; change buffer name when the load actually completes
+             ;; this can limit buffer-name flicker in mode-line.
+             (when (or (string-equal (nth 3 last-input-event)
+                                     "load-finished")
+                       (> (length title) 0))
                (with-current-buffer (xwidget-buffer xwidget)
                  (setq xwidget-webkit--title title)
                  (force-mode-line-update)